Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: net/cookies/canonical_cookie.h

Issue 1615773005: Rename first-party-only cookies to same-site cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed a few. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/canonical_cookie.h
diff --git a/net/cookies/canonical_cookie.h b/net/cookies/canonical_cookie.h
index da836b2ba916fd131df1835dfa8ef7000ca21830..eda4903c090704f2f540f311d12defcd9a409ee9 100644
--- a/net/cookies/canonical_cookie.h
+++ b/net/cookies/canonical_cookie.h
@@ -38,7 +38,7 @@ class NET_EXPORT CanonicalCookie {
const base::Time& last_access,
bool secure,
bool httponly,
- bool firstpartyonly,
+ bool samesite,
mmenke 2016/01/22 17:05:28 Should this be same_site? The property itself use
Mike West 2016/01/25 09:46:54 I'm basically following along with `httponly` here
mmenke 2016/01/25 18:47:10 I'd say go with `http_only`/`same_site`
Mike West 2016/01/26 11:05:45 `same_site` is done in this patch. I'll do `http_o
CookiePriority priority);
// This constructor does canonicalization but not validation.
@@ -70,7 +70,7 @@ class NET_EXPORT CanonicalCookie {
const base::Time& expiration,
bool secure,
bool http_only,
- bool first_party_only,
+ bool samesite,
bool enforce_strict_secure,
CookiePriority priority);
@@ -85,7 +85,7 @@ class NET_EXPORT CanonicalCookie {
const base::Time& ExpiryDate() const { return expiry_date_; }
bool IsSecure() const { return secure_; }
bool IsHttpOnly() const { return httponly_; }
- bool IsFirstPartyOnly() const { return first_party_only_; }
+ bool IsSameSite() const { return samesite_; }
CookiePriority Priority() const { return priority_; }
bool IsDomainCookie() const {
return !domain_.empty() && domain_[0] == '.'; }
@@ -204,7 +204,7 @@ class NET_EXPORT CanonicalCookie {
base::Time last_access_date_;
bool secure_;
bool httponly_;
- bool first_party_only_;
+ bool samesite_;
CookiePriority priority_;
};

Powered by Google App Engine
This is Rietveld 408576698