ios/net/cookies/system_cookie_util_unittest.mm - Issue 1615773005: Rename first-party-only cookies to same-site cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/cookies/system_cookie_util_unittest.mm

Issue 1615773005: Rename first-party-only cookies to same-site cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a few. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/net/cookies/system_cookie_util_unittest.mm

diff --git a/ios/net/cookies/system_cookie_util_unittest.mm b/ios/net/cookies/system_cookie_util_unittest.mm

index 96b5b6fb1793513f0782d516a0a4a88b39cb009a..2a629aa1b443fe2b898747ba828ba61165f00ab9 100644

--- a/ios/net/cookies/system_cookie_util_unittest.mm

+++ b/ios/net/cookies/system_cookie_util_unittest.mm

@@ -32,7 +32,7 @@ void CheckSystemCookie(const base::Time& expires, bool secure, bool httponly) {

expires,

base::Time(), // last_access

secure, httponly,

- false, // first_party_only

+ false, // samesite

mmenke 2016/01/25 18:47:10 same_site (x2)

Mike West 2016/01/26 11:05:45 Done (x2)

net::COOKIE_PRIORITY_DEFAULT);

// Convert it to system cookie.

base::scoped_nsobject<NSHTTPCookie> system_cookie(

@@ -125,7 +125,7 @@ TEST(CookieUtil, SystemCookieFromBadCanonicalCookie) {

base::Time(), // last_access

false, // secure

false, // httponly

- false, // first_party_only

+ false, // samesite

net::COOKIE_PRIORITY_DEFAULT);

// Convert it to system cookie.

base::scoped_nsobject<NSHTTPCookie> system_cookie(

« ios/net/cookies/cookie_store_ios_unittest.mm ('K') | « ios/net/cookies/cookie_store_ios_unittest.mm ('k') | net/cookies/canonical_cookie.h » ('j') | net/cookies/canonical_cookie.h » ('J')