Implement new willStartMainResourceRequest method of blink::WebApplicationCacheHost

Implement new willStartMainResourceRequest method of blink::WebApplicationCacheHost

This separates the frame-walking code from the appcache-setup code, allowing
the next Blink patch in this sequence to handle frame-walking on the Blink side.

BUG=343272
TBR=kinuko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251187

[adamk, 2014-02-12 22:21:39]

https://codereview.chromium.org/161303003/ is the Blink patch that adds this
API, and https://codereview.chromium.org/161213003 is the Blink patch that'll
follow this one up.

[michaeln, 2014-02-12 22:26:47]

lgtm, thnx for posting the following cls

[adamk, 2014-02-12 22:28:19]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:29:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/161573002/1

[commit-bot: I haz the power, 2014-02-12 22:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:29:57]

No file was found in this patchset.

[adamk, 2014-02-12 22:35:40]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:38:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/161573002/1

[commit-bot: I haz the power, 2014-02-13 00:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:53:13]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[adamk, 2014-02-13 00:56:03]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:57:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/161573002/1

[michaeln, 2014-02-13 01:09:20]

https://codereview.chromium.org/161573002/diff/1/content/child/appcache/web_a...
File content/child/appcache/web_application_cache_host_impl.h (right):

https://codereview.chromium.org/161573002/diff/1/content/child/appcache/web_a...
content/child/appcache/web_application_cache_host_impl.h:52:
blink::WebURLRequest&, const blink::WebApplicationCacheHost*);
oh... can you also override this method to do nothing class
WorkerWebApplicationCacheHostImpl.

[michaeln, 2014-02-13 01:09:31]

The CQ bit was unchecked by michaeln@chromium.org

[adamk, 2014-02-13 18:46:01]

TBRing kinuko for content/worker/ owners.

https://codereview.chromium.org/161573002/diff/1/content/child/appcache/web_a...
File content/child/appcache/web_application_cache_host_impl.h (right):

https://codereview.chromium.org/161573002/diff/1/content/child/appcache/web_a...
content/child/appcache/web_application_cache_host_impl.h:52:
blink::WebURLRequest&, const blink::WebApplicationCacheHost*);
On 2014/02/13 01:09:20, michaeln wrote:
> oh... can you also override this method to do nothing class
> WorkerWebApplicationCacheHostImpl.

Done.

[adamk, 2014-02-13 18:46:04]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:48:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/161573002/470001

[commit-bot: I haz the power, 2014-02-13 19:59:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/161573002/470001

[adamk, 2014-02-13 21:11:48]

Strange, I'm getting a clang compile error:

../../content/worker/worker_webapplicationcachehost_impl.h:23:68:error:
[chromium-style] Overriding method must be marked with OVERRIDE.
      blink::WebURLRequest&, const blink::WebApplicationCacheHost*);
                                                                   ^
                                                                    OVERRIDE
1 error generated.

But none of the other overridden methods in that header are marked OVERRIDE, and
we don't normally use OVERRIDE when implementing Blink API. Not clear on why
this is happening, any insight would be appreciated.

[adamk, 2014-02-13 22:27:27]

On 2014/02/13 21:11:48, adamk wrote:
> Strange, I'm getting a clang compile error:
> 
> ../../content/worker/worker_webapplicationcachehost_impl.h:23:68:error:
> [chromium-style] Overriding method must be marked with OVERRIDE.
>       blink::WebURLRequest&, const blink::WebApplicationCacheHost*);
>                                                                    ^
>                                                                     OVERRIDE
> 1 error generated.
> 
> But none of the other overridden methods in that header are marked OVERRIDE,
and
> we don't normally use OVERRIDE when implementing Blink API. Not clear on why
> this is happening, any insight would be appreciated.

Oh, looks like this isn't actually blocking the CQ, so it's not a worry. Now
just waiting on android bot...

[commit-bot: I haz the power, 2014-02-13 23:40:37]

Change committed as 251187