Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 161213003: Fix layering of ApplicationCacheHost (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
CC:
blink-reviews, dcheng, eseidel
Visibility:
Public.

Description

Fix layering of ApplicationCacheHost This patch moves the frame-walking code from Chromium's WebApplicationCacheHostImpl into WebCore::ApplicationCacheHost, which breaks that class's dependency on the public/web API. That allows blink::WebApplicationCacheHost{,Client} to move to public/platform. With the addition of a factory method on FrameLoaderClient, this also allos ApplicationCacheHost.cpp to move next to its header file in core/loader/appcache. ApplicationCacheHostInternal.h remains for now, but in the long run it can probably be removed (though the ownership semantics aren't completely clear to me). BUG=343272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167359

Patch Set 1 #

Patch Set 2 : The real thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -540 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + Source/core/loader/appcache/ApplicationCacheHost.cpp View 1 3 chunks +24 lines, -13 lines 0 comments Download
A + Source/core/loader/appcache/ApplicationCacheHostInternal.h View 1 1 chunk +9 lines, -6 lines 0 comments Download
M Source/web/ApplicationCacheHost.cpp View 1 1 chunk +0 lines, -251 lines 0 comments Download
D Source/web/ApplicationCacheHostInternal.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/web.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + public/platform/WebApplicationCacheHost.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
A + public/platform/WebApplicationCacheHostClient.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M public/web/WebApplicationCacheHost.h View 1 1 chunk +2 lines, -123 lines 0 comments Download
M public/web/WebApplicationCacheHostClient.h View 1 1 chunk +2 lines, -57 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
adamk
6 years, 10 months ago (2014-02-14 00:51:49 UTC) #1
eseidel
FYI, Frame ownership is moving into the embedder: https://codereview.chromium.org/156123004/
6 years, 10 months ago (2014-02-14 00:54:31 UTC) #2
adamk
On 2014/02/14 00:54:31, eseidel wrote: > FYI, Frame ownership is moving into the embedder: > ...
6 years, 10 months ago (2014-02-14 00:56:55 UTC) #3
adamk
+dcheng for discussion of frame tree walking
6 years, 10 months ago (2014-02-14 01:39:56 UTC) #4
michaeln
lgtm > (though the ownership semantics aren't completely clear to me) DocumentLoader owns (ApplicationCacheHost owns ...
6 years, 10 months ago (2014-02-14 02:12:46 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 10 months ago (2014-02-14 10:20:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161213003/30001
6 years, 10 months ago (2014-02-14 10:20:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 10:39:27 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16018
6 years, 10 months ago (2014-02-14 10:39:28 UTC) #9
adamk
ping abarth for public/ OWNERS
6 years, 10 months ago (2014-02-18 18:15:59 UTC) #10
abarth-chromium
public/ LGTM
6 years, 10 months ago (2014-02-18 18:20:17 UTC) #11
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-18 18:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161213003/30001
6 years, 10 months ago (2014-02-18 18:25:46 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:31:21 UTC) #14
Message was sent while issue was closed.
Change committed as 167359

Powered by Google App Engine
This is Rietveld 408576698