Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1615653012: Roll buildtools forward by one. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools forward by one. Brings in https://codereview.chromium.org/1616263006 roll clang-format 242086:r258123 New: - include sorting (disabled by default for -style=Chromium) - a toggle to disable comment formatting (will be needed transitionally for blink formatting) - bug fixes BUG=564077 TBR=scottmg@chromium.org Committed: https://crrev.com/eccc4bd0953d74e230155fda21199a8bc46b660a Cr-Commit-Position: refs/heads/master@{#371076}

Patch Set 1 #

Patch Set 2 : no sortincludes for blink for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/.clang-format View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
4 years, 11 months ago (2016-01-22 21:54:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615653012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615653012/20001
4 years, 11 months ago (2016-01-22 21:56:36 UTC) #4
scottmg
lgtm
4 years, 11 months ago (2016-01-22 21:59:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 23:29:50 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 23:31:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eccc4bd0953d74e230155fda21199a8bc46b660a
Cr-Commit-Position: refs/heads/master@{#371076}

Powered by Google App Engine
This is Rietveld 408576698