Issue 1616263006: roll clang-format 242086:r258123

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1616263006: roll clang-format 242086:r258123 (Closed)

Created:
4 years, 11 months ago by Nico

Modified:
4 years, 11 months ago

Reviewers:
scottmg

Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

roll clang-format 242086:r258123 New: - include sorting (disabled by default for -style=Chromium) - a toggle to disable comment formatting (will be needed transitionally for blink formatting) - bug fixes BUG=564077 TBR=scottmg@chromium.org Committed: 222bd42ce39d1bd8f08fe089b066f49c469e1cdf

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clang_format/README.chromium	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	linux64/clang-format.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mac/clang-format.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	win/clang-format.exe.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

Committed patchset #1 (id:1) manually as 222bd42ce39d1bd8f08fe089b066f49c469e1cdf (presubmit successful).

4 years, 11 months ago (2016-01-22 21:47:50 UTC) #3

scottmg

4 years, 11 months ago (2016-01-22 21:52:47 UTC) #4

Message was sent while issue was closed.

Ooh, header sorting, cool. Does it not handle all our weird windows.h, etc.
cases, or just haven't tried it yet?

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages