Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Transfer multi-request logic from PasswordStore to AffiliatedMatchHelper Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index 02df82bc04671ec11bb4bec43d07dfc9f12d3c5d..ff19a56e786c00d2551b29f92ecb9bb01ab505fa 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -155,6 +155,11 @@ class PasswordStore : protected PasswordStoreSync,
// The request will be cancelled if the consumer is destroyed.
virtual void GetAutofillableLogins(PasswordStoreConsumer* consumer);
+ // Same as above, but also fetches web realms affiliated with Android
+ // credentials and sets forms' |affiliated_web_realm|.
+ virtual void GetAutofillableLoginsWithAffiliatedRealms(
+ PasswordStoreConsumer* consumer);
+
// Gets the complete list of PasswordForms that are blacklist entries,
// and notify |consumer| on completion. The request will be cancelled if the
// consumer is destroyed.
@@ -358,6 +363,17 @@ class PasswordStore : protected PasswordStoreSync,
// Finds all non-blacklist PasswordForms, and notifies the consumer.
void GetAutofillableLoginsImpl(scoped_ptr<GetLoginsRequest> request);
+ // Same as above, but also makes a request to fill affiliated web realms in
+ // Android credentials.
+ void GetAutofillableLoginsWithAffiliatedRealmsImpl(
+ scoped_ptr<GetLoginsRequest> request);
+
+ // Send a request to AffiliationMatchHelper to fetch affiliated web realms and
+ // fill |affiliated_web_realm| in |forms|.
+ void FillAffiliatedWebRealms(
+ scoped_ptr<ScopedVector<autofill::PasswordForm>> forms,
+ scoped_ptr<GetLoginsRequest> request);
+
// Finds all blacklist PasswordForms, and notifies the consumer.
void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request);
@@ -365,6 +381,12 @@ class PasswordStore : protected PasswordStoreSync,
void NotifySiteStats(const GURL& origin_domain,
scoped_ptr<GetLoginsRequest> request);
+ // Notifies |request| about the autofillable logins with affiliated web
+ // realms for Android credentials.
+ void NotifyLoginsWithAffiliatedRealms(
+ scoped_ptr<ScopedVector<autofill::PasswordForm>> obtained_forms,
+ scoped_ptr<GetLoginsRequest> request);
+
// Extended version of GetLoginsImpl that also returns credentials stored for
// the specified affiliated Android applications. That is, it finds all
// PasswordForms with a signon_realm that is either:

Powered by Google App Engine
This is Rietveld 408576698