components/autofill/core/common/password_form.h - Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Transfer multi-request logic from PasswordStore to AffiliatedMatchHelper Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.cc ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | components/password_manager/core/browser/password_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index d110376d6fa322220daef73da1ece74d3fc10db1..93f7dda64b4fa2a203ed5cc279d0bf989fb3bd15 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -107,6 +107,11 @@ struct PasswordForm {

// When parsing an HTML form, this must always be set.

GURL action;

+ // The realm affiliated with the Android application, if the form is an

+ // Android credential. Otherwise, the string is empty. If there are several

+ // realms affiliated with the application, random realm is chosen.

engedy 2016/03/02 14:22:10 nit: +web+ realm Furthermore, could you please me

kolos1 2016/03/07 10:46:59 Done.

+ std::string affiliated_web_realm;

// The name of the submit button used. Optional; only used in scoring

// of PasswordForm results from the database to make matches as tight as

// possible.