Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: components/autofill/core/common/password_form.h

Issue 1615653005: [Password manager] Human readable origins for Android credentials on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Transfer multi-request logic from PasswordStore to AffiliatedMatchHelper Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 // the PasswordManager for form autofill; that is, the action of the saved 100 // the PasswordManager for form autofill; that is, the action of the saved
101 // credentials must match the action of the form on the page to be autofilled. 101 // credentials must match the action of the form on the page to be autofilled.
102 // If this is empty / not available, it will result in a "restricted" IE-like 102 // If this is empty / not available, it will result in a "restricted" IE-like
103 // autofill policy, where we wait for the user to type in his username before 103 // autofill policy, where we wait for the user to type in his username before
104 // autofilling the password. In these cases, after successful login the action 104 // autofilling the password. In these cases, after successful login the action
105 // URL will automatically be assigned by the PasswordManager. 105 // URL will automatically be assigned by the PasswordManager.
106 // 106 //
107 // When parsing an HTML form, this must always be set. 107 // When parsing an HTML form, this must always be set.
108 GURL action; 108 GURL action;
109 109
110 // The realm affiliated with the Android application, if the form is an
111 // Android credential. Otherwise, the string is empty. If there are several
112 // realms affiliated with the application, random realm is chosen.
engedy 2016/03/02 14:22:10 nit: +web+ realm Furthermore, could you please me
kolos1 2016/03/07 10:46:59 Done.
113 std::string affiliated_web_realm;
114
110 // The name of the submit button used. Optional; only used in scoring 115 // The name of the submit button used. Optional; only used in scoring
111 // of PasswordForm results from the database to make matches as tight as 116 // of PasswordForm results from the database to make matches as tight as
112 // possible. 117 // possible.
113 // 118 //
114 // When parsing an HTML form, this must always be set. 119 // When parsing an HTML form, this must always be set.
115 base::string16 submit_element; 120 base::string16 submit_element;
116 121
117 // The name of the username input element. Optional (improves scoring). 122 // The name of the username input element. Optional (improves scoring).
118 // 123 //
119 // When parsing an HTML form, this must always be set. 124 // When parsing an HTML form, this must always be set.
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>; 307 using ConstPasswordFormMap = std::map<base::string16, const PasswordForm*>;
303 308
304 // For testing. 309 // For testing.
305 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout); 310 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
306 std::ostream& operator<<(std::ostream& os, const PasswordForm& form); 311 std::ostream& operator<<(std::ostream& os, const PasswordForm& form);
307 std::ostream& operator<<(std::ostream& os, PasswordForm* form); 312 std::ostream& operator<<(std::ostream& os, PasswordForm* form);
308 313
309 } // namespace autofill 314 } // namespace autofill
310 315
311 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 316 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698