Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1615633002: [Media Router] Check for stamped first run flow before getting height. (Closed)

Created:
4 years, 11 months ago by apacible
Modified:
4 years, 11 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Check for stamped first run flow before getting height. Currently, shownComponentsChanged_() assumes the first run flow has been stamped before getting the offsetHeight. This is not always the case if the first run flow has already been acknowledged but the current view of the media-router-container is modified. Committed: https://crrev.com/d485ba70f05e5fe831ae90625a44bf5b0d880dd7 Cr-Commit-Position: refs/heads/master@{#371343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
apacible
PTAL, thanks!
4 years, 11 months ago (2016-01-21 02:59:55 UTC) #3
imcheng
lgtm
4 years, 11 months ago (2016-01-25 19:30:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615633002/1
4 years, 11 months ago (2016-01-25 21:51:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 23:11:58 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 23:14:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d485ba70f05e5fe831ae90625a44bf5b0d880dd7
Cr-Commit-Position: refs/heads/master@{#371343}

Powered by Google App Engine
This is Rietveld 408576698