chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js - Issue 1615633002: [Media Router] Check for stamped first run flow before getting height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 1615633002: [Media Router] Check for stamped first run flow before getting height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

index 9d0450f906c7fbaa67c80337ecfb4b3fdcc73d84..ee506f1b8d14df7776b9148b1947ec8d37e1a969 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

@@ -1069,7 +1069,8 @@ Polymer({

if (this.computeShowFirstRunFlow_(showFirstRunFlow, currentView)) {

// Ensures that first run flow elements have finished stamping.

this.async(function() {

- var firstRunFlowHeight = this.$$('#first-run-flow').offsetHeight;

+ var firstRunFlowHeight = this.$$('#first-run-flow') ?

+ this.$$('#first-run-flow').offsetHeight : 0;

this.$['container-header'].style.marginTop = firstRunFlowHeight + 'px';

this.$['sink-list-view'].style.marginTop =

firstRunFlowHeight + headerHeight + 'px';

« no previous file with comments | « no previous file | no next file » | no next file with comments »