Set rootBounds to null for cross-origin observations.

Set rootBounds to null for cross-origin observations.

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org

Committed: https://crrev.com/4a43ad53c455dfa688d57da40300efe6c37e28ce
Cr-Commit-Position: refs/heads/master@{#373113}

[ojan, 2016-01-21 23:56:43]

https://codereview.chromium.org/1615573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js
(right):

https://codereview.chromium.org/1615573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js:10:
var description = function(msg) { descriptionString = msg }
I don't think you need to do all this monkey patching of js-test. Instead, I
think you just need:
window.jsTestIsAsync = true;

Then when your test is done, call finishJSTest().

[szager1, 2016-01-22 00:23:39]

https://codereview.chromium.org/1615573002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js
(right):

https://codereview.chromium.org/1615573002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/helper-functions.js:10:
var description = function(msg) { descriptionString = msg }
On 2016/01/21 23:56:43, ojan wrote:
> I don't think you need to do all this monkey patching of js-test. Instead, I
> think you just need:
> window.jsTestIsAsync = true;
> 
> Then when your test is done, call finishJSTest().

I tried that; didn't work :)

[ojan, 2016-01-22 19:27:53]

We shouldn't monkey-patch js-test. That increases maintenance burden when we
want to make improvements to it. If it can't do what you need it to do, we can
extend it appropriately. Lets chat in person to understand what the issue is.

[szager1, 2016-01-30 01:01:25]

On 2016/01/22 19:27:53, ojan wrote:
> We shouldn't monkey-patch js-test. That increases maintenance burden when we
> want to make improvements to it. If it can't do what you need it to do, we can
> extend it appropriately. Lets chat in person to understand what the issue is.

I created a patch to fix js-test.js; I will rebase this on top of it once it
lands:

https://codereview.chromium.org/1648123004

[ojan, 2016-02-02 05:52:17]

lgtm once rebased on top of the dependent patch.

[szager1, 2016-02-02 23:01:57]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-02-02 23:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/1615573002/#ps40001
(title: "Get rid of js-test.js monkey patching")

[commit-bot: I haz the power, 2016-02-02 23:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615573002/40001

[commit-bot: I haz the power, 2016-02-03 01:20:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 01:21:24]

Description was changed from

==========
Set rootBounds to null for cross-origin observations.

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org
==========

to

==========
Set rootBounds to null for cross-origin observations.

BUG=540528
R=ojan@chromium.org,esprehn@chromium.org

Committed: https://crrev.com/4a43ad53c455dfa688d57da40300efe6c37e28ce
Cr-Commit-Position: refs/heads/master@{#373113}
==========

[commit-bot: I haz the power, 2016-02-03 01:21:25]

Patchset 3 (id:??) landed as
https://crrev.com/4a43ad53c455dfa688d57da40300efe6c37e28ce
Cr-Commit-Position: refs/heads/master@{#373113}