Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1648123004: Fix lazy test result printing. (Closed)

Created:
4 years, 10 months ago by szager1
Modified:
4 years, 10 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix lazy test result printing. Previously, description() and isSuccessfullyParsed() would add their results to the top of the document immediately, even if setPrintTestResultsLazily() was used. This caused problems for async tests that relied on precise document offset measurements (such as the IntersectionObserver tests). With this change, setPrintTestResultsLazily() will cause *all* test output to be delayed until finishJSTest(). BUG=540528 R=ojan@chromium.org,esprehn@chromium.org Committed: https://crrev.com/34c8bfd59f4d8943df2620620cd00ae1d0fc1999 Cr-Commit-Position: refs/heads/master@{#372902}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
szager1
4 years, 10 months ago (2016-01-30 00:58:55 UTC) #1
ojan
lgtm
4 years, 10 months ago (2016-02-02 05:51:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648123004/1
4 years, 10 months ago (2016-02-02 05:51:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 06:53:26 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 06:54:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34c8bfd59f4d8943df2620620cd00ae1d0fc1999
Cr-Commit-Position: refs/heads/master@{#372902}

Powered by Google App Engine
This is Rietveld 408576698