PNaCl cleanup: Remove TempFile class and use base::File instead

PNaCl cleanup: Remove TempFile class and use base::File instead

Following earlier cleanups, TempFile is now just a wrapper around
base::File anyway.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/6a5d054c1aad5bc458ce61a776dd4b15a2fd2531
Cr-Commit-Position: refs/heads/master@{#370752}

[Mark Seaborn, 2016-01-21 01:17:21]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 01:18:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615523003/20001

[commit-bot: I haz the power, 2016-01-21 02:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 02:15:37]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Mark Seaborn, 2016-01-21 02:39:22]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 02:41:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615523003/40001

[commit-bot: I haz the power, 2016-01-21 04:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 04:17:11]

Dry run: This issue passed the CQ dry run.

[Mark Seaborn, 2016-01-21 05:20:21]

mseaborn@chromium.org changed reviewers:
+ bbudge@chromium.org

[bbudge, 2016-01-21 18:37:39]

LGTM w/comment

https://codereview.chromium.org/1615523003/diff/40001/components/nacl/rendere...
File components/nacl/renderer/plugin/pnacl_translate_thread.h (right):

https://codereview.chromium.org/1615523003/diff/40001/components/nacl/rendere...
components/nacl/renderer/plugin/pnacl_translate_thread.h:141:
std::vector<base::File>* obj_files_;
Have you considered making this a const ref? Or is there something about
base::File that makes this impossible?

Same for nexe_file_ though to a lesser extent.

[Mark Seaborn, 2016-01-21 19:18:21]

https://codereview.chromium.org/1615523003/diff/40001/components/nacl/rendere...
File components/nacl/renderer/plugin/pnacl_translate_thread.h (right):

https://codereview.chromium.org/1615523003/diff/40001/components/nacl/rendere...
components/nacl/renderer/plugin/pnacl_translate_thread.h:141:
std::vector<base::File>* obj_files_;
On 2016/01/21 18:37:38, bbudge wrote:
> Have you considered making this a const ref? Or is there something about
> base::File that makes this impossible?

I started off keeping the 'const', but it didn't work because we call
base::File::Seek(), and that currently requires a non-const base::File.

That would work for a "const std::vector<base::File*>", but not for a "const
std::vector<base::File>".

This is kind of arbitrary, because Seek() doesn't modify the base::File itself,
it modifies the FD that the base::File points to.

Seek() could have a 'const' qualifier added to it, in principle, but people
aren't always consistent about whether they want 'const' to be transitive, so
it's not clear what people would expect it to mean for a base::File.

[Mark Seaborn, 2016-01-21 19:30:43]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-01-21 19:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615523003/40001

[commit-bot: I haz the power, 2016-01-21 19:40:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 19:41:46]

Description was changed from

==========
PNaCl cleanup: Remove TempFile class and use base::File instead

Following earlier cleanups, TempFile is now just a wrapper around
base::File anyway.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
PNaCl cleanup: Remove TempFile class and use base::File instead

Following earlier cleanups, TempFile is now just a wrapper around
base::File anyway.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/6a5d054c1aad5bc458ce61a776dd4b15a2fd2531
Cr-Commit-Position: refs/heads/master@{#370752}
==========

[commit-bot: I haz the power, 2016-01-21 19:41:47]

Patchset 3 (id:??) landed as
https://crrev.com/6a5d054c1aad5bc458ce61a776dd4b15a2fd2531
Cr-Commit-Position: refs/heads/master@{#370752}