PNaCl cleanup: Remove TempFile class and use base::File instead

components/nacl/renderer/plugin/pnacl_translate_thread.h

Index: components/nacl/renderer/plugin/pnacl_translate_thread.h
diff --git a/components/nacl/renderer/plugin/pnacl_translate_thread.h b/components/nacl/renderer/plugin/pnacl_translate_thread.h
index 1092d02e2aadc83b3be037187aba3f78b91b0a65..1e3c1a9725fbbedd451c49ad0cedd7036525c5e6 100644
--- a/components/nacl/renderer/plugin/pnacl_translate_thread.h
+++ b/components/nacl/renderer/plugin/pnacl_translate_thread.h
@@ -10,6 +10,7 @@
 #include <deque>
 #include <vector>
 
+#include "base/files/file.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/nacl/renderer/plugin/plugin_error.h"
@@ -24,7 +25,6 @@ namespace plugin {
 
 class NaClSubprocess;
 class PnaclCoordinator;
-class TempFile;
 
 class PnaclTranslateThread {
  public:
@@ -37,9 +37,9 @@ class PnaclTranslateThread {
   void SetupState(const pp::CompletionCallback& finish_callback,
                   NaClSubprocess* compiler_subprocess,
                   NaClSubprocess* ld_subprocess,
-                  const std::vector<TempFile*>* obj_files,
+                  std::vector<base::File>* obj_files,
                   int num_threads,
-                  TempFile* nexe_file,
+                  base::File* nexe_file,
                   ErrorInfo* error_info,
                   PP_PNaClOptions* pnacl_options,
                   const std::string& architecture_attributes,
@@ -79,7 +79,7 @@ class PnaclTranslateThread {
 
  private:
   ppapi::proxy::SerializedHandle GetHandleForSubprocess(
-      TempFile* file, int32_t open_flags, base::ProcessId peer_pid);
+      base::File* file, int32_t open_flags, base::ProcessId peer_pid);
 
   // Helper thread entry point for compilation. Takes a pointer to
   // PnaclTranslateThread and calls DoCompile().
@@ -138,9 +138,9 @@ class PnaclTranslateThread {
   int64_t compile_time_;
 
   // Data about the translation files, owned by the coordinator
-  const std::vector<TempFile*>* obj_files_;
+  std::vector<base::File>* obj_files_;

[bbudge, 2016/01/21 18:37:38]

Have you considered making this a const ref? Or is there something about
base::File that makes this impossible?

Same for nexe_file_ though to a lesser extent.

[Mark Seaborn, 2016/01/21 19:18:21]

I started off keeping the 'const', but it didn't work because we call
base::File::Seek(), and that currently requires a non-const base::File.

That would work for a "const std::vector<base::File*>", but not for a "const
std::vector<base::File>".

This is kind of arbitrary, because Seek() doesn't modify the base::File itself,
it modifies the FD that the base::File points to.

Seek() could have a 'const' qualifier added to it, in principle, but people
aren't always consistent about whether they want 'const' to be transitive, so
it's not clear what people would expect it to mean for a base::File.

   int num_threads_;
-  TempFile* nexe_file_;
+  base::File* nexe_file_;
   ErrorInfo* coordinator_error_info_;
   PP_PNaClOptions* pnacl_options_;
   std::string architecture_attributes_;