third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp - Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

index 585cce045032888fb588166ca86e782fd5564437..cbaebda358615c27d1986d0d6ef5d73659ef3543 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp

@@ -152,7 +152,7 @@ PassRefPtr<SkImageFilter> FEConvolveMatrix::createImageFilter(SkiaImageFilterBui

OwnPtr<SkScalar[]> kernel = adoptArrayPtr(new SkScalar[numElements]);

for (int i = 0; i < numElements; ++i)

kernel[i] = SkFloatToScalar(m_kernelMatrix[numElements - 1 - i]);

- SkImageFilter::CropRect cropRect = getCropRect(builder.cropOffset());

+ SkImageFilter::CropRect cropRect = getCropRect();

return adoptRef(SkMatrixConvolutionImageFilter::Create(kernelSize, kernel.get(), gain, bias, target, tileMode, convolveAlpha, input.get(), &cropRect));

}