third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp - Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

Issue 1615453003: Remove crop offset from SkiaImageFilterBuilder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

index eec1dcf1bdfcae6862a91cb4a1db27e1e68565fb..ec70f565a8d1210c342eba5008c681ecb3f5d7de 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

@@ -204,7 +204,7 @@ PassRefPtr<SkImageFilter> FEComposite::createImageFilterInternal(SkiaImageFilter

{

RefPtr<SkImageFilter> foreground(builder.build(inputEffect(0), operatingColorSpace(), !mayProduceInvalidPreMultipliedPixels()));

RefPtr<SkImageFilter> background(builder.build(inputEffect(1), operatingColorSpace(), !mayProduceInvalidPreMultipliedPixels()));

- SkImageFilter::CropRect cropRect = getCropRect(builder.cropOffset());

+ SkImageFilter::CropRect cropRect = getCropRect();

RefPtr<SkXfermode> mode;

if (m_type == FECOMPOSITE_OPERATOR_ARITHMETIC)

mode = adoptRef(SkArithmeticMode::Create(SkFloatToScalar(m_k1), SkFloatToScalar(m_k2), SkFloatToScalar(m_k3), SkFloatToScalar(m_k4), requiresPMColorValidation));