Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16154031: Un-refcount AutofillWebData and TokenWebData (Closed)

Created:
7 years, 6 months ago by Cait (Slow)
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, joth, Jói
CC:
chromium-reviews, Raman Kakilate, akalin, benquan, Raghu Simha, haitaol1, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, markusheintz_, Ilya Sherman, android-webview-reviews_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge upstream changes #

Patch Set 3 : nits #

Patch Set 4 : Rebase on ToT #

Total comments: 8

Patch Set 5 : nits #

Patch Set 6 : Fix TemplateURL tests #

Patch Set 7 : Merge ToT and fix gyp error #

Patch Set 8 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -197 lines) Patch
M android_webview/browser/aw_form_database_service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_form_database_service.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_form_database.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 2 3 4 5 6 3 chunks +31 lines, -1 line 0 comments Download
M chrome/browser/signin/token_service.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/signin/token_service.cc View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 7 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/webdata/token_web_data.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/webdata/token_web_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_data_service.h View 1 2 3 4 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 8 chunks +16 lines, -17 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 1 2 3 4 5 6 7 6 chunks +20 lines, -40 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 1 2 3 4 5 6 7 12 chunks +36 lines, -36 lines 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/webdata/web_data_service_unittest.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -6 lines 0 comments Download
M components/webdata/common/web_data_service_base.h View 1 2 3 4 5 6 3 chunks +5 lines, -12 lines 0 comments Download
M components/webdata/common/web_data_service_test_util.h View 1 chunk +6 lines, -7 lines 0 comments Download
M components/webdata/common/web_data_service_test_util.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Cait (Slow)
Hi Jói, Can you give this CL a once over before I send it off ...
7 years, 6 months ago (2013-06-07 16:00:08 UTC) #1
Jói
LGTM
7 years, 6 months ago (2013-06-07 16:53:06 UTC) #2
joth
lgtm stamp
7 years, 6 months ago (2013-06-07 18:08:58 UTC) #3
Cait (Slow)
Lei: This CL consists mostly of converting instances of scoped_refptr<XyzWebData> to XzyWebData*, and has been ...
7 years, 6 months ago (2013-06-07 20:35:13 UTC) #4
Lei Zhang
chrome/ lgtm with a new more nits. Thanks for doing some lint cleanup along the ...
7 years, 6 months ago (2013-06-07 20:42:49 UTC) #5
Cait (Slow)
Thanks for the quick review! https://codereview.chromium.org/16154031/diff/8001/chrome/browser/signin/token_service.h File chrome/browser/signin/token_service.h (right): https://codereview.chromium.org/16154031/diff/8001/chrome/browser/signin/token_service.h#newcode231 chrome/browser/signin/token_service.h:231: // Web data service ...
7 years, 6 months ago (2013-06-07 21:00:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/16154031/18001
7 years, 6 months ago (2013-06-07 21:02:23 UTC) #7
commit-bot: I haz the power
Change committed as 205038
7 years, 6 months ago (2013-06-08 05:43:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/16154031/60001
7 years, 6 months ago (2013-06-11 18:10:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/16154031/85001
7 years, 6 months ago (2013-06-11 18:59:10 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 23:11:20 UTC) #11
Message was sent while issue was closed. 
Change committed as 205670

Powered by Google App Engine
This is Rietveld 408576698