chrome/browser/sync/profile_sync_components_factory_impl.cc - Issue 16154031: Un-refcount AutofillWebData and TokenWebData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 16154031: Un-refcount AutofillWebData and TokenWebData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase on ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc

index 5c997c30a23e5863c8ae8ab210dedd8beee4935a..79382a02bfc23c49ac0d0727af521d3ef6608085 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc

@@ -347,14 +347,14 @@ base::WeakPtr<syncer::SyncableService> ProfileSyncComponentsFactoryImpl::

syncer::PRIORITY_PREFERENCES)->AsWeakPtr();

case syncer::AUTOFILL:

case syncer::AUTOFILL_PROFILE: {

- if (!web_data_service_.get())

+ if (!web_data_service_)

return base::WeakPtr<syncer::SyncableService>();

if (type == syncer::AUTOFILL) {

return AutocompleteSyncableService::FromWebDataService(

- web_data_service_.get())->AsWeakPtr();

+ web_data_service_)->AsWeakPtr();

} else {

return AutofillProfileSyncableService::FromWebDataService(

- web_data_service_.get())->AsWeakPtr();

+ web_data_service_)->AsWeakPtr();

}

case syncer::APPS: