Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/testing/dart/status_expression.dart

Issue 16154017: Rename RuntimeError to CyclicIntializationError, as per spec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix bad merge in js_helper.dart Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/status_expression.dart
diff --git a/tools/testing/dart/status_expression.dart b/tools/testing/dart/status_expression.dart
index 8fae9e10969f6537ed68b7b1ce11bf7a6ac724aa..957924927416e8c2e5beee6be39af7a3989ea687 100644
--- a/tools/testing/dart/status_expression.dart
+++ b/tools/testing/dart/status_expression.dart
@@ -236,13 +236,13 @@ class ExpressionParser {
scanner.advance();
SetExpression value = parseSetExpression();
if (scanner.current != Token.RIGHT_PAREN) {
- throw new RuntimeError("Missing right parenthesis in expression");
+ throw new FormatException("Missing right parenthesis in expression");
}
scanner.advance();
return value;
}
if (!new RegExp(r"^\w+$").hasMatch(scanner.current)) {
- throw new RuntimeError(
+ throw new FormatException(
"Expected identifier in expression, got ${scanner.current}");
}
SetExpression value = new SetConstant(scanner.current);
@@ -277,7 +277,7 @@ class ExpressionParser {
scanner.advance();
BooleanExpression value = parseBooleanExpression();
if (scanner.current != Token.RIGHT_PAREN) {
- throw new RuntimeError("Missing right parenthesis in expression");
+ throw new FormatException("Missing right parenthesis in expression");
}
scanner.advance();
return value;
@@ -286,12 +286,12 @@ class ExpressionParser {
// The only atomic booleans are of the form $variable == value or the
// form $variable.
if (scanner.current != Token.DOLLAR_SYMBOL) {
- throw new RuntimeError(
+ throw new FormatException(
"Expected \$ in expression, got ${scanner.current}");
}
scanner.advance();
if (!new RegExp(r"^\w+$").hasMatch(scanner.current)) {
- throw new RuntimeError(
+ throw new FormatException(
"Expected identifier in expression, got ${scanner.current}");
}
TermVariable left = new TermVariable(scanner.current);
@@ -301,7 +301,7 @@ class ExpressionParser {
bool negate = scanner.current == Token.NOT_EQUALS;
scanner.advance();
if (!new RegExp(r"^\w+$").hasMatch(scanner.current)) {
- throw new RuntimeError(
+ throw new FormatException(
"Expected identifier in expression, got ${scanner.current}");
}
TermConstant right = new TermConstant(scanner.current);

Powered by Google App Engine
This is Rietveld 408576698