Rename RuntimeError to CyclicIntializationError, as per spec.

sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart

Index: sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart b/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
index aaf30d7d4b78978f1f6ffaf676206507b0a6776d..5b4f36a109a42e96bd7ca63087cfeee43b00a3d7 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart
@@ -428,7 +428,7 @@ class JsVariableMirror implements VariableMirror {
     int length = descriptor.length;
     var code = fieldCode(descriptor.codeUnitAt(length - 1));
     if (code == 0) {
-      throw new RuntimeError('Bad field descriptor: $descriptor');
+      throw new ArgumentError('Bad field descriptor: $descriptor');

[ahe, 2013/06/04 13:14:11]

What makes you think this is an argument error?

[Lasse Reichstein Nielsen, 2013/06/13 08:08:57]

Descriptor is an argument. It's being tested in some way, and if it doesn't
satisfy the test, an error is thrown that says that the descriptor is bad.
That sounds like an argument error.
Could be wrong ofcourse, and you are free to find another error to use.

[ahe, 2013/06/13 09:59:14]

I'm sorry, I'm on a crusade against incorrect uses of "generic" exceptions: any
exception thrown gets exposed to the user because it bubbles up through the call
stack. So I think it is important that the exception conveys the right message.

The message an ArgumentError coveys is that the user provided a wrong argument
to a method (or factory). However, this factory is not accessible to users and
the user has no control over the descriptor argument, and this exception might
occur when a user writes code like this:

someClassMirror.variables

There are no arguments here, but an internal error might happen at runtime, and
I need to know the descriptor to debug the problem. The users can't fix it
themselves: there's nothing wrong with any arguments (a getter doesn't take
arguments).

     }
     bool hasGetter = (code & 3) != 0;
     bool hasSetter = (code >> 2) != 0;
@@ -481,7 +481,7 @@ function(reflectee) {
 ''');
     String callName = JS('String|Null', '#(#)', extractCallName, reflectee);
     if (callName == null) {
-      throw new RuntimeError('Cannot find callName on "$reflectee"');
+      throw new ArgumentError('Cannot find callName on "$reflectee"');

[ahe, 2013/06/04 13:14:11]

What makes you think this is an argument error?  What argument in particular do
you feel this error is related to?

[Lasse Reichstein Nielsen, 2013/06/13 08:08:57]

True, I probably misread the code due to the inlined code-as-text above.
Looks more like a StateError.

[ahe, 2013/06/13 09:59:14]

This is what StateError says it represents: "The operation was not allowed by
the current state of the object."

See above rant: the user has done nothing to put the JsClosureMirror in a bad
state, and cannot do anything to bring it to a different state.  The object has
no states besides being there or not (all fields are final, and all fields refer
to immutable objects).

You can only obtain an instance of this object by calling "reflect(foo)" where
foo is a closure.  If it is not a closure, reflect will return a
JsInstanceMirror.

This represents an internal error in the runtime implementation of the Dart
platform.  I think RuntimeError (or a string) conveys that much better than
StateError.

     }
     int parameterCount = int.parse(callName.split(r'$')[1]);
     if (reflectee is BoundClosure) {