chrome/browser/nacl_host/nacl_process_host.h - Issue 16154005: Remove dependency from NaCl code on chrome_constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 16154005: Remove dependency from NaCl code on chrome_constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/nacl_host/nacl_broker_host_win.cc ('k') | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | chrome/browser/nacl_host/nacl_process_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/nacl_process_host.h

diff --git a/chrome/browser/nacl_host/nacl_process_host.h b/chrome/browser/nacl_host/nacl_process_host.h

index 5a0d80b7ebf8a584673c125fb6d0264e4edac1f4..ed871c6699fc3d385160424f67939ba565d96b0c 100644

--- a/chrome/browser/nacl_host/nacl_process_host.h

+++ b/chrome/browser/nacl_host/nacl_process_host.h

@@ -112,6 +112,11 @@ class NaClProcessHost : public content::BrowserChildProcessHostDelegate {

// is enabled.

SocketDescriptor GetDebugStubSocketHandle();

#endif

+#if defined(OS_WIN)

+ // Get path to NaCl loader on local disk if possible.

Mark Seaborn 2013/05/31 19:42:30 Nit: "disk" -> "filesystem", since a lot of system

+ // |exe_path| does not change if the method fails.

+ bool GetNaclAppPath(base::FilePath& exe_path);

dmichael (off chromium) 2013/05/31 19:42:18 style nit: We use pointers for out-params in Chrom

Mark Seaborn 2013/05/31 19:42:30 This should be spelled as "NaCl", not "Nacl". Can

+#endif

// Get path to manifest on local disk if possible.

base::FilePath GetManifestPath();

bool LaunchSelLdr();