Remove dependency from NaCl code on chrome_constants.

chrome/browser/nacl_host/nacl_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
 #define CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
 
 #include "build/build_config.h"
 
 #include "base/files/file_path.h"
@@ skipping 94 matching lines @@
 #elif defined(OS_LINUX)
   bool LaunchNaClGdb(base::ProcessId pid);
   void OnNaClGdbAttached();
 #endif
 #if defined(OS_POSIX)
   // Create bound TCP socket in the browser process so that the NaCl GDB debug
   // stub can use it to accept incoming connections even when the Chrome sandbox
   // is enabled.
   SocketDescriptor GetDebugStubSocketHandle();
 #endif
+#if defined(OS_WIN)
+  // Get path to NaCl loader on local disk if possible.

[Mark Seaborn, 2013/05/31 19:42:30]

Nit: "disk" -> "filesystem", since a lot of systems don't have disks these days
:-)

+  // |exe_path| does not change if the method fails.
+  bool GetNaclAppPath(base::FilePath& exe_path);

[dmichael (off chromium), 2013/05/31 19:42:18]

style nit: We use pointers for out-params in Chromium
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Reference_Argu...

(you get used to it...  it does help with knowing at a call-site that an
argument can change).

[Mark Seaborn, 2013/05/31 19:42:30]

This should be spelled as "NaCl", not "Nacl".  Can you make this
"GetNaCl64ExePath"?  "App" is vague, and this really refers specifically to
nacl64.exe.

+#endif
   // Get path to manifest on local disk if possible.
   base::FilePath GetManifestPath();
   bool LaunchSelLdr();
 
   // BrowserChildProcessHostDelegate implementation:
   virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
   virtual void OnProcessLaunched() OVERRIDE;
 
   void OnResourcesReady();
 
@@ skipping 95 matching lines @@
   PluginListener ipc_plugin_listener_;
   // Browser host for plugin process.
   scoped_ptr<content::BrowserPpapiHost> ppapi_host_;
 
   int render_view_id_;
 
   DISALLOW_COPY_AND_ASSIGN(NaClProcessHost);
 };
 
 #endif  // CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_