Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: ui/base/ime/input_method_auralinux.cc

Issue 1615073005: Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_auralinux.cc
diff --git a/ui/base/ime/input_method_auralinux.cc b/ui/base/ime/input_method_auralinux.cc
index d6ceeaa59e2c4ad826f4862ef4f4f6614f0aacd5..ca9931f06f777e215e9012f9da4b9f1e3bb9fdca 100644
--- a/ui/base/ime/input_method_auralinux.cc
+++ b/ui/base/ime/input_method_auralinux.cc
@@ -46,19 +46,6 @@
void InputMethodAuraLinux::DispatchKeyEvent(ui::KeyEvent* event) {
DCHECK(event->type() == ET_KEY_PRESSED || event->type() == ET_KEY_RELEASED);
DCHECK(system_toplevel_window_focused());
- if (!system_toplevel_window_focused()) {
- GetLogCollector()->AddString(
- "Unexpected DispatchKeyEvent: InputMethod is not active.");
- GetLogCollector()->DumpLogs();
- // There are random issues that the keyboard typing doesn't work.
- // The root cause might be the InputMethod::OnFocus() is not correctly
- // called when the top-level window is activated
- // (in DNWA::HandleActivationChanged).
- // Calls OnFocus here to unblock the keyboard typing.
- OnFocus();
- } else {
- GetLogCollector()->ClearLogs();
- }
// If no text input client, do nothing.
if (!GetTextInputClient()) {
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698