Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2181)

Unified Diff: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart

Issue 1615023002: Issue 25538. Fix for 'analysis.implemented' notification and private members. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_implemented_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
diff --git a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
index 5391d5ed1e89c25bb008ab2580401bfde5f79716..42e72137e535184fdf36a08b20fa70b62126204b 100644
--- a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
+++ b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
@@ -57,21 +57,23 @@ class ImplementedComputer {
if (element.isSynthetic || _isStatic(element)) {
return;
}
- String name = element.displayName;
- if (name != null && _hasOverride(name)) {
+ if (_hasOverride(element)) {
_addImplementedMember(element);
}
}
- bool _hasOverride(String name) {
+ bool _hasOverride(Element element) {
+ String name = element.displayName;
+ LibraryElement library = element.library;
for (ClassElement subtype in subtypes) {
- MethodElement method = subtype.getMethod(name);
- if (method != null) {
- return !method.isStatic;
+ ClassMemberElement subElement = subtype.getMethod(name);
+ if (subElement == null) {
+ subElement = subtype.getField(name);
}
- FieldElement field = subtype.getField(name);
- if (field != null) {
- return !field.isStatic;
+ if (subElement != null &&
+ !subElement.isStatic &&
+ subElement.isAccessibleIn(library)) {
+ return true;
}
}
return false;
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/notification_implemented_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698