Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/analysis_server/test/analysis/notification_implemented_test.dart

Issue 1615023002: Issue 25538. Fix for 'analysis.implemented' notification and private members. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_implemented_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_implemented_test.dart b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
index d5cde860d996ea8d9c91b3d9413d19171142f1fd..ab0e0c1525ddb284327695f52d30ab18dc65dc67 100644
--- a/pkg/analysis_server/test/analysis/notification_implemented_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
@@ -276,6 +276,38 @@ class C extends A {
assertHasImplementedMember('m() {} // A');
}
+ test_method_withMethod_private_differentLib() async {
+ addFile(
+ '$testFolder/lib.dart',
+ r'''
+import 'test.dart';
+class B extends A {
+ void _m() {}
+}
+''');
+ addTestFile('''
+class A {
+ _m() {} // A
+}
+''');
+ await prepareImplementedElements();
+ assertNoImplementedMember('_m() {} // A');
+ }
+
+ test_method_withMethod_private_sameLibrary() async {
+ addTestFile('''
+class A {
+ _m() {} // A
+}
+class B extends A {
+ _m() {} // B
+}
+''');
+ await prepareImplementedElements();
+ assertHasImplementedMember('_m() {} // A');
+ assertNoImplementedMember('_m() {} // B');
+ }
+
test_method_withMethod_wasAbstract() async {
addTestFile('''
abstract class A {
« no previous file with comments | « pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698