Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1615023002: Issue 25538. Fix for 'analysis.implemented' notification and private members. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart View 1 chunk +11 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-21 16:23:11 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-21 16:59:11 UTC) #2
scheglov
4 years, 11 months ago (2016-01-21 17:49:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cba8d0d7c31490a097a5dc21f89a218dd873e89d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698