Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 1614943002: [crankshaft] Remove the useless HMapEnumLength instruction. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove the useless HMapEnumLength instruction. There's no need to have HMapEnumLength as a dedicated instruction, as it can be expressed using a HLoadNamedField plus an HBitwiseAnd operation. R=jarin@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/441af2e6b3a4fd1c72dc302b895752f1d53daa87 Cr-Commit-Position: refs/heads/master@{#33439}

Patch Set 1 #

Patch Set 2 : Put NoObservableSideEffectsScope there #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -235 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 3 chunks +5 lines, -26 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-21 14:04:32 UTC) #1
Benedikt Meurer
Hey Jaro, Some small cleanup I ran across. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-21 14:05:45 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-21 15:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614943002/20001
4 years, 11 months ago (2016-01-21 15:24:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 15:26:23 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:27:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/441af2e6b3a4fd1c72dc302b895752f1d53daa87
Cr-Commit-Position: refs/heads/master@{#33439}

Powered by Google App Engine
This is Rietveld 408576698