Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 1614943002: [crankshaft] Remove the useless HMapEnumLength instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Put NoObservableSideEffectsScope there Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index 13ada8c606cfa7a79384bb2c7dfbb8bddfa442fa..18af113e9923057fbbd0ac662eaba442b55b2594 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -117,7 +117,6 @@ class LChunkBuilder;
V(LoadNamedField) \
V(LoadNamedGeneric) \
V(LoadRoot) \
- V(MapEnumLength) \
V(MathFloorOfDiv) \
V(MathMinMax) \
V(MaybeGrowElements) \
@@ -2493,31 +2492,6 @@ class HCallRuntime final : public HCall<1> {
};
-class HMapEnumLength final : public HUnaryOperation {
- public:
- DECLARE_INSTRUCTION_FACTORY_P1(HMapEnumLength, HValue*);
-
- Representation RequiredInputRepresentation(int index) override {
- return Representation::Tagged();
- }
-
- DECLARE_CONCRETE_INSTRUCTION(MapEnumLength)
-
- protected:
- bool DataEquals(HValue* other) override { return true; }
-
- private:
- explicit HMapEnumLength(HValue* value)
- : HUnaryOperation(value, HType::Smi()) {
- set_representation(Representation::Smi());
- SetFlag(kUseGVN);
- SetDependsOnFlag(kMaps);
- }
-
- bool IsDeletable() const override { return true; }
-};
-
-
class HUnaryMathOperation final : public HTemplateInstruction<2> {
public:
static HInstruction* New(Isolate* isolate, Zone* zone, HValue* context,
@@ -6027,6 +6001,11 @@ class HObjectAccess final {
Representation::UInteger8());
}
+ static HObjectAccess ForMapBitField3() {
+ return HObjectAccess(kInobject, Map::kBitField3Offset,
+ Representation::Integer32());
+ }
+
static HObjectAccess ForNameHashField() {
return HObjectAccess(kInobject,
Name::kHashFieldOffset,
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698