[Cast,Android] Fix the RuntimeException crasher

[Cast,Android] Fix the RuntimeException crasher

Seems like throwing a RuntimeException is quite an overkill.
In particular, we still seem to get onResult() callback even if the GMS core connection is suspended.
Replaced the exception with a warning message in a cherrypickable way (the crash happens in M48).

BUG=579718
Committed: https://crrev.com/54894bc428bc5cc7b036cf2d20221e45468a4349
Cr-Commit-Position: refs/heads/master@{#370687}

[whywhat, 2016-01-21 11:16:08]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-01-21 11:16:09]

PTaL

[whywhat, 2016-01-21 11:27:14]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 11:27:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614833003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614833003/1

[mlamouri (slow - plz ping), 2016-01-21 12:07:30]

https://codereview.chromium.org/1614833003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
(right):

https://codereview.chromium.org/1614833003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java:220:
Log.w(TAG, "Invalid state: %d", mState);
I think it would be safer to replace throwInvalidState() with this Log.d() in
the place where the crash happens instead of changing the behaviour of all these
other methods.

[whywhat, 2016-01-21 12:09:01]

Only change behavior of one method

[whywhat, 2016-01-21 12:10:15]

PTAL

Technically speaking, it doesn't seem to be an invalid state anymore since it
can actually happen so I just allow the second state as valid for onResult().

[whywhat, 2016-01-21 12:19:57]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 12:20:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614833003/20001

[commit-bot: I haz the power, 2016-01-21 13:01:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 13:01:30]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-01-21 13:41:28]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-01-21 13:41:28]

lgtm

[commit-bot: I haz the power, 2016-01-21 13:42:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614833003/20001

[commit-bot: I haz the power, 2016-01-21 13:46:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-21 13:47:26]

Description was changed from

==========
[Cast,Android] Fix the RuntimeException crasher

Seems like throwing a RuntimeException is quite an overkill.
In particular, we still seem to get onResult() callback even if the GMS core
connection is suspended.
Replaced the exception with a warning message in a cherrypickable way (the crash
happens in M48).

BUG=579718
==========

to

==========
[Cast,Android] Fix the RuntimeException crasher

Seems like throwing a RuntimeException is quite an overkill.
In particular, we still seem to get onResult() callback even if the GMS core
connection is suspended.
Replaced the exception with a warning message in a cherrypickable way (the crash
happens in M48).

BUG=579718

Committed: https://crrev.com/54894bc428bc5cc7b036cf2d20221e45468a4349
Cr-Commit-Position: refs/heads/master@{#370687}
==========

[commit-bot: I haz the power, 2016-01-21 13:47:27]

Patchset 2 (id:??) landed as
https://crrev.com/54894bc428bc5cc7b036cf2d20221e45468a4349
Cr-Commit-Position: refs/heads/master@{#370687}