Reland of Remove MockConstraints

Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of https://codereview.chromium.org/1605513002/ )
>
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
Committed: https://crrev.com/5183c4281bfd06efe4d6ecc70fd7e86d260916ba
Cr-Commit-Position: refs/heads/master@{#370729}

[hta - Chromium, 2016-01-21 08:43:10]

Created Reland of move MockConstraints

[tommi (sloooow) - chröme, 2016-01-21 08:47:36]

in what file are the tests?

[tommi (sloooow) - chröme, 2016-01-21 08:49:37]

On 2016/01/21 08:47:36, tommi-chromium wrote:
> in what file are the tests?

ah, nevermind, I guess you're working on it but the review email was sent out
when this cr was created.

[hta - Chromium, 2016-01-21 08:51:48]

Description was changed from

==========
Reland of move MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1608073002/ )

Reason for revert:
Re-landing with fixed tests.

Original issue's description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
> 
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.
> 
> Original issue's description:
> > Remove MockConstraints
> >
> > The purpose of the MockConstraints class was to verify that only legal
> > constraint names were passed. This is now done inside Blink
> > in MediaConstraintsImpl.cpp, so this class isn't needed any more.
> >
> > BUG=543997
> >
> > Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
> > Cr-Commit-Position: refs/heads/master@{#370219}
> 
> TBR=jochen@chromium.org,tommi@chromium.org,hta@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=543997
> 
> Committed: https://crrev.com/e0dd75ac197c5df17ebe34a5f3295ea54d9e463f
> Cr-Commit-Position: refs/heads/master@{#370238}

TBR=jochen@chromium.org,tommi@chromium.org,samli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543997
==========

to

==========
Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
> 
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

[hta - Chromium, 2016-01-21 08:55:56]

PTAL - the test fixes are in.

Yes, having the revert button send out mail surprised me.

[tommi (sloooow) - chröme, 2016-01-21 09:00:19]

lgtm

[jochen (gone - plz use gerrit), 2016-01-21 16:17:15]

lgtm

[hta - Chromium, 2016-01-21 16:45:11]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-01-21 16:45:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614733002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614733002/180001

[commit-bot: I haz the power, 2016-01-21 18:16:34]

Description was changed from

==========
Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
> 
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

to

==========
Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
> 
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

[commit-bot: I haz the power, 2016-01-21 18:16:35]

Committed patchset #2 (id:180001)

[commit-bot: I haz the power, 2016-01-21 18:17:35]

Description was changed from

==========
Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
> 
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

to

==========
Reland of Remove MockConstraints

Reason for revert:
Re-landing with fixed tests.

Original rollback description:
> Revert of Remove MockConstraints (patchset #1 id:1 of
https://codereview.chromium.org/1605513002/ )
>
> Reason for revert:
> Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across
all bots.

Original issue's description:

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997

Committed: https://crrev.com/5183c4281bfd06efe4d6ecc70fd7e86d260916ba
Cr-Commit-Position: refs/heads/master@{#370729}
==========

[commit-bot: I haz the power, 2016-01-21 18:17:35]

Patchset 2 (id:??) landed as
https://crrev.com/5183c4281bfd06efe4d6ecc70fd7e86d260916ba
Cr-Commit-Position: refs/heads/master@{#370729}