Reland of Remove MockConstraints

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 336 matching lines @@
         } else if (constraint.m_name.equals(kCpuOveruseEncodeRsdThreshold)) {
             result.googCpuOveruseEncodeRsdThreshold.setExact(atoi(constraint.m_value.utf8().c_str()));
         } else if (constraint.m_name.equals(kCpuOveruseEncodeUsage)) {
             result.googCpuOveruseEncodeUsage.setExact(toBoolean(constraint.m_value));
         } else if (constraint.m_name.equals(kHighStartBitrate)) {
             result.googHighStartBitrate.setExact(atoi(constraint.m_value.utf8().c_str()));
         } else if (constraint.m_name.equals(kPayloadPadding)) {
             result.googPayloadPadding.setExact(toBoolean(constraint.m_value));
         } else if (constraint.m_name.equals(kTestConstraint1)
             || constraint.m_name.equals(kTestConstraint2)) {
-            // These constraints are only for testing parsing. Ignore them.
+            // These constraints are only for testing parsing.
+            // Values 0 and 1 are legal, all others are a ConstraintError.
+            if (!constraint.m_value.equals("0") && !constraint.m_value.equals("1"))
+                errorState.throwConstraintError("Illegal value for constraint", constraint.m_name);
         } else {
             // TODO(hta): UMA stats for unknown constraints passed.
             // https://crbug.com/576613
             WTF_LOG(Media, "Unknown constraint name detected");
             errorState.throwConstraintError("Unknown name of constraint detected", constraint.m_name);
         }
     }
 }
 
 static WebMediaConstraints createFromNamedConstraints(WebVector<WebMediaConstraint>& mandatory, const WebVector<WebMediaConstraint>& optional, MediaErrorState& errorState)
@@ skipping 147 matching lines @@
 
 WebMediaConstraints create()
 {
     WebMediaConstraints constraints;
     constraints.initialize();
     return constraints;
 }
 
 } // namespace MediaConstraintsImpl
 } // namespace blink