Issue 16147004: do aligned reads in ContainsOnlyOneByte

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16147004: do aligned reads in ContainsOnlyOneByte (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

do aligned reads in ContainsOnlyOneByte R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15023

Patch Set 2 : added block checking #

Total comments: 2

Patch Set 3 : comments addressed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -11 lines)			Patch
	M	src/api.cc	View	1 2	1 chunk	+38 lines, -6 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2	4 chunks	+27 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM if comments are addressed. https://codereview.chromium.org/16147004/diff/3001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/16147004/diff/3001/src/api.cc#newcode4313 src/api.cc:4313: static const uint64_t value ...

7 years, 6 months ago (2013-06-07 09:19:06 UTC) #2

dcarney

7 years, 6 months ago (2013-06-10 07:35:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r15023 (presubmit successful).