Speculative fix to a crash caused by hitting the dangerous download infobar.

Speculative fix to a crash caused by hitting the dangerous download infobar.

There is no good explanation of the crash:
1. When clicking on a dangerous download, we set mPendingRequest and start
the infobar.
2. When user dismiss the infobar, we reset mPendingRequest.
3. If mPendingRequest is non null, a 2nd request will not trigger any
infobar.
So at anytime, there are at most 1 dangerous infobar.
And if mPendingRequest is non null, there should be an infobar showing,
vice versa.

So this a speculative fix to the crash from the crash stack we have
seen.

BUG=579707
Committed: https://crrev.com/7efc4d5ec2db8b17a7aa28723283524f6591cd6a
Cr-Commit-Position: refs/heads/master@{#372153}

[qinmin, 2016-01-20 23:52:05]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org

[qinmin, 2016-01-20 23:52:06]

PTAL

[qinmin, 2016-01-20 23:59:31]

Patchset #1 (id:1) has been deleted

[qinmin, 2016-01-21 00:07:23]

Patchset #1 (id:20001) has been deleted

[qinmin, 2016-01-21 00:32:56]

Patchset #2 (id:60001) has been deleted

[qinmin, 2016-01-21 00:33:01]

Patchset #1 (id:40001) has been deleted

[David Trainor- moved to gerrit, 2016-01-22 17:36:31]

lgtm

[qinmin, 2016-01-22 17:47:01]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-01-22 17:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614453003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614453003/80001

[commit-bot: I haz the power, 2016-01-22 17:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 17:49:41]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qinmin, 2016-01-28 19:41:25]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-01-28 19:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1614453003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-28 19:42:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614453003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614453003/100001

[commit-bot: I haz the power, 2016-01-28 20:31:06]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-01-28 20:32:13]

Description was changed from

==========
Speculative fix to a crash caused by hitting the dangerous download infobar.

There is no good explanation of the crash:
1. When clicking on a dangerous download, we set mPendingRequest and start
the infobar.
2. When user dismiss the infobar, we reset mPendingRequest.
3. If mPendingRequest is non null, a 2nd request will not trigger any
infobar.
So at anytime, there are at most 1 dangerous infobar.
And if mPendingRequest is non null, there should be an infobar showing,
vice versa.

So this a speculative fix to the crash from the crash stack we have
seen.

BUG=579707
==========

to

==========
Speculative fix to a crash caused by hitting the dangerous download infobar.

There is no good explanation of the crash:
1. When clicking on a dangerous download, we set mPendingRequest and start
the infobar.
2. When user dismiss the infobar, we reset mPendingRequest.
3. If mPendingRequest is non null, a 2nd request will not trigger any
infobar.
So at anytime, there are at most 1 dangerous infobar.
And if mPendingRequest is non null, there should be an infobar showing,
vice versa.

So this a speculative fix to the crash from the crash stack we have
seen.

BUG=579707

Committed: https://crrev.com/7efc4d5ec2db8b17a7aa28723283524f6591cd6a
Cr-Commit-Position: refs/heads/master@{#372153}
==========

[commit-bot: I haz the power, 2016-01-28 20:32:13]

Patchset 2 (id:??) landed as
https://crrev.com/7efc4d5ec2db8b17a7aa28723283524f6591cd6a
Cr-Commit-Position: refs/heads/master@{#372153}