chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java - Issue 1614453003: Speculative fix to a crash caused by hitting the dangerous download infobar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

Issue 1614453003: Speculative fix to a crash caused by hitting the dangerous download infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

index 3718e7605768c13dfea749d8666fd3cacce5cee7..4d0b01787575a9c56665b44ea6d5b33c091593c9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

@@ -58,6 +58,7 @@ public class ChromeDownloadDelegate implements ContentViewDownloadDelegate {

@Override

public void onInfoBarButtonClicked(boolean confirm) {

assert mTab != null;

+ if (mPendingRequest == null) return;

if (mPendingRequest.hasDownloadId()) {

nativeDangerousDownloadValidated(mTab, mPendingRequest.getDownloadId(), confirm);

if (confirm) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »