Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1614453002: Subzero. X8664. Fix broken call sequence. (Closed)

Created:
4 years, 11 months ago by John
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adds x86-64 spec2k tests to presubmit #

Patch Set 3 : Fixes target typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Makefile.standalone View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
John
4 years, 11 months ago (2016-01-20 21:12:28 UTC) #2
sehr
lgtm
4 years, 11 months ago (2016-01-20 21:31:03 UTC) #3
John
4 years, 11 months ago (2016-01-20 21:44:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4ab4fbed8ef1cd0d8eafb205c86ae451ce92b3f6 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698