src/IceTargetLoweringX86BaseImpl.h - Issue 1614453002: Subzero. X8664. Fix broken call sequence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 1614453002: Subzero. X8664. Fix broken call sequence. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixes target typo. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 28f3f2f00a4d0437e77076559fa7f16c935893bd..2669fcfb837f25e96c8c02ae000fe3548635308c 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -2152,7 +2152,7 @@ void TargetX86Base<TraitsType>::lowerCall(const InstCall *Instr) {

// Ensure there is enough space for the fstp/movs for floating returns.

Variable *Dest = Instr->getDest();

const Type DestTy = Dest ? Dest->getType() : IceType_void;

- if (Traits::X86_PASS_SCALAR_FP_IN_XMM) {

+ if (!Traits::X86_PASS_SCALAR_FP_IN_XMM) {

if (isScalarFloatingType(DestTy)) {

ParameterAreaSizeBytes =

std::max(static_cast<size_t>(ParameterAreaSizeBytes),

« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »