Report all Drive search results even if resource metadata is not fully loaded.

Report all Drive search results even if resource metadata is not fully loaded.

By this patch, a search result entry whose metadata is not fetched yet is
temporarily added to the hidden "drive/other" directory for making it possible
to appear in the search result UI. Normal feed loading routine will move it
back to the right place once the real metadata is loaded.

BUG=181075
TEST=Search "a" during the initial load of an account with large number of files
R=hashimoto@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203091

[kinaba, 2013-05-30 01:14:26]

ptal

[hashimoto, 2013-05-30 02:13:10]

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/search_operation.cc (right):

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:52: // It will be
moved to the right place after
nit: Please make it clarify the timing when the added entry will moved to the 
right place. (IIUC, it's when the local metadata gets synced.)

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:55: if (error ==
FILE_ERROR_OK || error == FILE_ERROR_EXISTS)
IIRC, AddEntry does not return FILE_ERROR_EXISTS for a resource ID which was not
found.

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:56:
resource_metadata->RefreshEntry(entry, &drive_file_path, &entry);
RefreshEntry here seems redandunt.
I think you might want to call GetResourceEntryById and GetFilePath. (note:
|out_file_path| argument of GetResourceEntryById will be removed soon.
https://codereview.chromium.org/16107004/)

[kinaba, 2013-05-30 03:19:36]

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_system/search_operation.cc (right):

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:52: // It will be
moved to the right place after
On 2013/05/30 02:13:10, hashimoto wrote:
> nit: Please make it clarify the timing when the added entry will moved to the 
> right place. (IIUC, it's when the local metadata gets synced.)

Done.

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:55: if (error ==
FILE_ERROR_OK || error == FILE_ERROR_EXISTS)
On 2013/05/30 02:13:10, hashimoto wrote:
> IIRC, AddEntry does not return FILE_ERROR_EXISTS for a resource ID which was
not
> found.

As chatted offline, this is for the case when the (true) parent is NOT_FOUND.

https://codereview.chromium.org/16142003/diff/1003/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_system/search_operation.cc:56:
resource_metadata->RefreshEntry(entry, &drive_file_path, &entry);
On 2013/05/30 02:13:10, hashimoto wrote:
> RefreshEntry here seems redandunt.
> I think you might want to call GetResourceEntryById and GetFilePath. (note:
> |out_file_path| argument of GetResourceEntryById will be removed soon.
> https://codereview.chromium.org/16107004/)

Done.

[hashimoto, 2013-05-30 03:25:12]

lgtm

[commit-bot: I haz the power, 2013-05-30 03:26:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/16142003/9001

[commit-bot: I haz the power, 2013-05-30 03:52:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/16142003/9001

[commit-bot: I haz the power, 2013-05-30 05:40:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/16142003/19001

[kinaba, 2013-05-30 05:59:04]

Committed patchset #3 manually as r203091 (presubmit successful).