Report all Drive search results even if resource metadata is not fully loaded.

chrome/browser/chromeos/drive/file_system/search_operation.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/file_system/search_operation.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 24 matching lines @@
   DCHECK(result);
 
   const ScopedVector<google_apis::ResourceEntry>& entries =
       resource_list->entries();
   result->reserve(entries.size());
   for (size_t i = 0; i < entries.size(); ++i) {
     ResourceEntry entry = ConvertToResourceEntry(*entries[i]);
     base::FilePath drive_file_path;
     FileError error = resource_metadata->RefreshEntry(
         entry, &drive_file_path, &entry);
-    if (error == FILE_ERROR_OK) {
-      result->push_back(SearchResultInfo(drive_file_path, entry));
-    } else if (error == FILE_ERROR_NOT_FOUND) {
-      // The result is absent in local resource metadata. There are two cases:
+    if (error == FILE_ERROR_NOT_FOUND) {
+      // The result is absent in local resource metadata. This can happen if
+      // the metadata is not synced to the latest server state yet. In that
+      // case, we temporarily add the file to the special "drive/other"
+      // directory in order to assign a path, which is needed to access the
+      // file through FileSystem API.
       //
-      // 1) Resource metadata is not up-to-date, and the entry has recently
-      //    been added to the drive. This is not a fatal error, so just skip to
-      //    add the result. We should soon receive XMPP update notification
-      //    and refresh both the metadata and search result UI in Files.app.
-      //
-      // 2) Resource metadata is not fully loaded.
-      // TODO(kinaba) crbug.com/181075:
-      //    In this case, we are doing "fast fetch" fetching directory lists on
-      //    the fly to quickly deliver results to the user. However, we have no
-      //    such equivalent for Search.
-    } else {
-      // Otherwise, it is a fatal error. Give up to return the search result.
+      // It will be moved to the right place after

[hashimoto, 2013/05/30 02:13:10]

nit: Please make it clarify the timing when the added entry will moved to the 
right place. (IIUC, it's when the local metadata gets synced.)

[kinaba, 2013/05/30 03:19:36]

Done.

+      entry.set_parent_resource_id(util::kDriveOtherDirSpecialResourceId);
+      error = resource_metadata->AddEntry(entry);
+      if (error == FILE_ERROR_OK || error == FILE_ERROR_EXISTS)

[hashimoto, 2013/05/30 02:13:10]

IIRC, AddEntry does not return FILE_ERROR_EXISTS for a resource ID which was not
found.

[kinaba, 2013/05/30 03:19:36]

As chatted offline, this is for the case when the (true) parent is NOT_FOUND.

+        resource_metadata->RefreshEntry(entry, &drive_file_path, &entry);

[hashimoto, 2013/05/30 02:13:10]

RefreshEntry here seems redandunt.
I think you might want to call GetResourceEntryById and GetFilePath. (note:
|out_file_path| argument of GetResourceEntryById will be removed soon.
https://codereview.chromium.org/16107004/)

[kinaba, 2013/05/30 03:19:36]

Done.

+    }
+    // Otherwise, it is a fatal error. Give up to return the search result.
+    if (error != FILE_ERROR_OK)
       return error;
-    }
+    result->push_back(SearchResultInfo(drive_file_path, entry));
   }
 
   return FILE_ERROR_OK;
 }
 
 }  // namespace
 
 SearchOperation::SearchOperation(
     base::SequencedTaskRunner* blocking_task_runner,
     JobScheduler* scheduler,
@@ skipping 85 matching lines @@
   if (error != FILE_ERROR_OK) {
     callback.Run(error, GURL(), scoped_ptr<std::vector<SearchResultInfo> >());
     return;
   }
 
   callback.Run(error, next_feed, result.Pass());
 }
 
 }  // namespace file_system
 }  // namespace drive