Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Issue 1614173002: Removal all idle-task implementations in toBlob (Closed)

Created:
4 years, 11 months ago by xlai (Olivia)
Modified:
4 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removal all idle-task implementations in toBlob BUG=564218 Committed: https://crrev.com/72fc4074be5f53812829e6272f5e246319f444bd Cr-Commit-Position: refs/heads/master@{#370908}

Patch Set 1 #

Patch Set 2 : Rebased with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -159 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-defaultpng.html View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-defaultpng-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-png.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-png-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-toBlob-toDataURL-race.js View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/toBlob/canvas-toBlob-defaultpng.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/toBlob/canvas-toBlob-defaultpng-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/toBlob/canvas-toBlob-toDataURL-race-imageEncoder-png.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/toBlob/canvas-toBlob-toDataURL-race-imageEncoder-png-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 3 chunks +3 lines, -59 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
xlai (Olivia)
I've cleaned up the code a bit, before shipping toBlob.
4 years, 11 months ago (2016-01-21 20:41:06 UTC) #2
Justin Novosad
All that sweat and tears. Sniff :'( lgtm
4 years, 11 months ago (2016-01-21 21:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1614173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1614173002/20001
4 years, 11 months ago (2016-01-22 03:24:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 04:57:32 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/72fc4074be5f53812829e6272f5e246319f444bd Cr-Commit-Position: refs/heads/master@{#370908}
4 years, 11 months ago (2016-01-22 04:59:27 UTC) #9
xlai (Olivia)
4 years, 11 months ago (2016-01-26 23:07:30 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1637163002/ by xlai@chromium.org.

The reason for reverting is: I want to pull back the implementations for
idle-tasks, because I find that it is possible that this implementation is the
one we should adopt in canvas.toBlob instead of the other implementation..

Powered by Google App Engine
This is Rietveld 408576698