third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 1614173002: Removal all idle-task implementations in toBlob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1614173002: Removal all idle-task implementations in toBlob (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased with master Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/toBlob/canvas-toBlob-toDataURL-race-imageEncoder-png-expected.txt ('k') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index 85f5d4e1e5d29d5ba45d9c62987d537e0bef5296..bf78b7a96810d9d098860f2040cb28fbf387476d 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -611,8 +611,7 @@ void HTMLCanvasElement::toBlob(ScriptState* scriptState, BlobCallback* callback,

RefPtr<CanvasAsyncBlobCreator> asyncCreatorRef = CanvasAsyncBlobCreator::create(imageDataRef.release(), encodingMimeType, imageData->size(), callback, scriptState->executionContext());

- // TODO(xlai): Remove idle-periods version of implementation completely, http://crbug.com/564218

- asyncCreatorRef->scheduleAsyncBlobCreation(false, quality);

+ asyncCreatorRef->scheduleAsyncBlobCreation(quality);

}

void HTMLCanvasElement::addListener(CanvasDrawListener* listener)