Pepper: Refactor FileInfo conversions.

Pepper: Refactor FileInfo conversions.

FileRef and FileIO both convert base::PlatformFileInfo to PP_FileInfo. I ran
into this while I was about to reimplement the same thing in the FileRef
refactor, and figured I may as well break out this simple refactor to its own
change.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204027

[yzshen1, 2013-06-04 05:22:28]

Only a few nits.

Thanks!

https://codereview.chromium.org/16140025/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_file_io_host.cc (right):

https://codereview.chromium.org/16140025/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_file_io_host.cc:30: using ppapi::TimeToPPTime;
This is not needed anymore.

https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
File ppapi/shared_impl/file_type_conversion.cc (right):

https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
ppapi/shared_impl/file_type_conversion.cc:80: PP_FileInfo *info_out) {
nit: '*' should be adjacent to PP_FileInfo.

https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
File ppapi/shared_impl/file_type_conversion.h (right):

https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
ppapi/shared_impl/file_type_conversion.h:29: PP_FileInfo *info_out);
nit: '*' should be adjacent to the type instead of the parameter name.

https://codereview.chromium.org/16140025/diff/1/webkit/plugins/ppapi/ppb_file...
File webkit/plugins/ppapi/ppb_file_ref_impl.cc (left):

https://codereview.chromium.org/16140025/diff/1/webkit/plugins/ppapi/ppb_file...
webkit/plugins/ppapi/ppb_file_ref_impl.cc:109:
DCHECK_EQ(PP_FILESYSTEMTYPE_EXTERNAL, file_system_type);
Does it make sense to perserve this DCHECK in the conversion function?

[teravest, 2013-06-04 14:19:07]

On Mon, Jun 3, 2013 at 11:22 PM,  <yzshen@chromium.org> wrote:
> Only a few nits.
>
> Thanks!
>
>
>
https://codereview.chromium.org/16140025/diff/1/content/renderer/pepper/peppe...
> File content/renderer/pepper/pepper_file_io_host.cc (right):
>
>
https://codereview.chromium.org/16140025/diff/1/content/renderer/pepper/peppe...
> content/renderer/pepper/pepper_file_io_host.cc:30: using
> ppapi::TimeToPPTime;
> This is not needed anymore.

Done.

>
>
https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
> File ppapi/shared_impl/file_type_conversion.cc (right):
>
>
https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
> ppapi/shared_impl/file_type_conversion.cc:80: PP_FileInfo *info_out) {
> nit: '*' should be adjacent to PP_FileInfo.

Done.

>
>
https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
> File ppapi/shared_impl/file_type_conversion.h (right):
>
>
https://codereview.chromium.org/16140025/diff/1/ppapi/shared_impl/file_type_c...
> ppapi/shared_impl/file_type_conversion.h:29: PP_FileInfo *info_out);
> nit: '*' should be adjacent to the type instead of the parameter name.

Done.

>
>
https://codereview.chromium.org/16140025/diff/1/webkit/plugins/ppapi/ppb_file...
> File webkit/plugins/ppapi/ppb_file_ref_impl.cc (left):
>
>
https://codereview.chromium.org/16140025/diff/1/webkit/plugins/ppapi/ppb_file...
> webkit/plugins/ppapi/ppb_file_ref_impl.cc:109:
> DCHECK_EQ(PP_FILESYSTEMTYPE_EXTERNAL, file_system_type);
> Does it make sense to perserve this DCHECK in the conversion function?

Sounds good. Done.

>
> https://codereview.chromium.org/16140025/

[yzshen1, 2013-06-04 16:14:24]

LGTM

[commit-bot: I haz the power, 2013-06-04 16:17:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/16140025/8001

[commit-bot: I haz the power, 2013-06-04 20:24:43]

Change committed as 204027