Pepper: Refactor FileInfo conversions.

webkit/plugins/ppapi/ppb_file_ref_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_file_ref_impl.h"
 
 #include "base/files/file_util_proxy.h"
 #include "base/platform_file.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 79 matching lines @@
 }
 
 void IgnoreCloseCallback(base::PlatformFileError error_code) {
 }
 
 void PlatformFileInfoToPPFileInfo(
     const base::PlatformFileInfo& file_info,
     PP_FileSystemType file_system_type,
     PP_FileInfo* info) {
   DCHECK(info);
-
-  info->size = file_info.size;
-  info->system_type = file_system_type;
-  info->creation_time = ::ppapi::TimeToPPTime(file_info.creation_time);
-  info->last_access_time = ::ppapi::TimeToPPTime(file_info.last_accessed);
-  info->last_modified_time = ::ppapi::TimeToPPTime(file_info.last_modified);
-
-  if (file_info.is_symbolic_link) {
-    // Only external filesystem may have symbolic link files.
-    DCHECK_EQ(PP_FILESYSTEMTYPE_EXTERNAL, file_system_type);

[yzshen1, 2013/06/04 05:22:28]

Does it make sense to perserve this DCHECK in the conversion function?

-    info->type = PP_FILETYPE_OTHER;
-  } else if (file_info.is_directory) {
-    info->type = PP_FILETYPE_DIRECTORY;
-  } else {
-    info->type = PP_FILETYPE_REGULAR;
-  }
+  ::ppapi::PlatformFileInfoToPepperFileInfo(file_info, file_system_type, info);
 }
 
 void GetFileInfoCallback(
     scoped_refptr<base::TaskRunner> task_runner,
     base::PlatformFile file,
     linked_ptr<PP_FileInfo> info,
     scoped_refptr<TrackedCallback> callback,
     base::PlatformFileError error_code,
     const base::PlatformFileInfo& file_info) {
   base::FileUtilProxy::Close(
@@ skipping 398 matching lines @@
           GetFileSystemURL(),
           base::Bind(&DidReadDirectory,
                      callback, base::Unretained(this), files, file_types),
           base::Bind(&DidFinishFileOperation, callback)))
     return PP_ERROR_FAILED;
   return PP_OK_COMPLETIONPENDING;
 }
 
 }  // namespace ppapi
 }  // namespace webkit