Issue 1613823003: Mege to XFA: Redo CPDF_PageObjects - part 1

Issue 1613823003: Mege to XFA: Redo CPDF_PageObjects - part 1 (Closed)

Created:
4 years, 11 months ago by Tom Sepez

Modified:
4 years, 11 months ago

Reviewers:
Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Mege to XFA: Redo CPDF_PageObjects - part 1 Original Review URL: https://codereview.chromium.org/1601093009 . (cherry picked from commit da9355139b5dce270be02af31db326d60f488e8c) Trivial conflicts/changes in fpdfeditpage.cpp and fpdfxfa_page.cpp. TBR=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b5b2a9162e3e5d17b233d912399daca9be5ed51b

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -79 lines)			Patch
M	core/include/fpdfapi/fpdf_page.h	View	7 chunks	+15 lines, -16 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page.cpp	View	5 chunks	+13 lines, -35 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdf_flatten.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdfeditpage.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfxfa/fpdfxfa_page.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	4 chunks	+3 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as b5b2a9162e3e5d17b233d912399daca9be5ed51b (presubmit successful).

4 years, 11 months ago (2016-01-21 19:04:40 UTC) #3

Message was sent while issue was closed.

lgtm