Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1601093009: Redo CPDF_PageObjects - part 1 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Redo CPDF_PageObjects - part 1 Remove default args. Remove unreachable code. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/da9355139b5dce270be02af31db326d60f488e8c

Patch Set 1 : First transformation #

Patch Set 2 : Second Transformation #

Patch Set 3 : Third Transformation #

Patch Set 4 : Fourth transformation #

Patch Set 5 : Remove redundant method call #

Patch Set 6 : Remove ClearCachedObjects #

Patch Set 7 : unique_ptr #

Patch Set 8 : Unfriending #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -78 lines) Patch
M core/include/fpdfapi/fpdf_page.h View 1 2 3 4 5 6 7 8 7 chunks +15 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 2 3 4 5 6 5 chunks +13 lines, -35 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 3 4 5 6 7 6 chunks +10 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 2 3 4 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Sepez
PTAL. I want to eventually get rid of the m_ObjectList which is the last CFX_PtrList, ...
4 years, 11 months ago (2016-01-21 01:04:37 UTC) #4
Oliver Chang
lgtm
4 years, 11 months ago (2016-01-21 18:41:24 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-21 18:51:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #9 (id:160001) manually as
da9355139b5dce270be02af31db326d60f488e8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698