Issue 1613233005: Merge to 2623 "[DevTools] Fix various bugs in Device Mode."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1613233005: Merge to 2623 "[DevTools] Fix various bugs in Device Mode." (Closed)

Created:
4 years, 11 months ago by dgozman

Modified:
4 years, 11 months ago

Reviewers:
pfeldman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

Merge to 2623 "[DevTools] Fix various bugs in Device Mode." > [DevTools] Fix various bugs in Device Mode. > > Most are visuals, see bug descritptions. > > BUG=578717, 578723, 578969, 578933, 579028, 578958, 578801, 578721 > > Review URL: https://codereview.chromium.org/1604013002 > > Cr-Commit-Position: refs/heads/master@{#370207} (cherry picked from commit 08b2434c3b25e13cd30ab2e1907be4ab03e85ff7) TBR=pfeldman Committed: https://chromium.googlesource.com/chromium/src/+/a3a42014fe90cac11f800b3af3a19e1fe2d618de

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -59 lines)			Patch
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js	View	14 chunks	+33 lines, -55 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/deviceModeToolbar.css	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css	View	2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dgozman

4 years, 11 months ago (2016-01-21 22:48:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3a42014fe90cac11f800b3af3a19e1fe2d618de.