Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1604013002: [DevTools] Fix various bugs in Device Mode. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-main-menu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix various bugs in Device Mode. Most are visuals, see bug descritptions. BUG=578717, 578723, 578969, 578933, 579028, 578958, 578801, 578721 Committed: https://crrev.com/08b2434c3b25e13cd30ab2e1907be4ab03e85ff7 Cr-Commit-Position: refs/heads/master@{#370207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 3 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 14 chunks +33 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeToolbar.css View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 2 chunks +7 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1601853003 Patch 1

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-19 19:29:46 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-19 19:31:46 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1601853003 Patch 1). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-19 19:33:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604013002/1
4 years, 11 months ago (2016-01-19 21:05:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 22:26:02 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 22:28:10 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/08b2434c3b25e13cd30ab2e1907be4ab03e85ff7
Cr-Commit-Position: refs/heads/master@{#370207}

Powered by Google App Engine
This is Rietveld 408576698