Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: trunk/src/chromeos/network/network_state.h

Issue 16132002: Revert 202503 "Revert 202478 "Revert 202388 "Remove NetworkState..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chromeos/network/managed_state.h ('k') | trunk/src/chromeos/network/network_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chromeos/network/network_state.h
===================================================================
--- trunk/src/chromeos/network/network_state.h (revision 202513)
+++ trunk/src/chromeos/network/network_state.h (working copy)
@@ -8,9 +8,12 @@
#include <string>
#include <vector>
-#include "base/values.h"
#include "chromeos/network/managed_state.h"
+namespace base {
+class DictionaryValue;
+}
+
namespace chromeos {
// Simple class to provide network state information about a network service.
@@ -42,12 +45,12 @@
const std::string& guid() const { return guid_; }
const std::string& connection_state() const { return connection_state_; }
const std::string& profile_path() const { return profile_path_; }
+ const std::string& proxy_config() const { return proxy_config_; }
const std::string& error() const { return error_; }
const std::string& error_details() const { return error_details_; }
bool auto_connect() const { return auto_connect_; }
bool favorite() const { return favorite_; }
int priority() const { return priority_; }
- const base::DictionaryValue& proxy_config() const { return proxy_config_; }
// Wireless property accessors
int signal_strength() const { return signal_strength_; }
bool connectable() const { return connectable_; }
@@ -97,14 +100,12 @@
std::string guid_;
std::string connection_state_;
std::string profile_path_;
+ std::string proxy_config_;
std::string error_;
std::string error_details_;
bool auto_connect_;
bool favorite_;
int priority_;
- // TODO(pneubeck): Remove this property once NetworkConfigurationHandler
- // provides proxy configuration. crbug/241775
- base::DictionaryValue proxy_config_;
// IPConfig properties.
// Note: These do not correspond to actual Shill.Service properties
// but are derived from the service's corresponding IPConfig object.
« no previous file with comments | « trunk/src/chromeos/network/managed_state.h ('k') | trunk/src/chromeos/network/network_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698