Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: trunk/src/chromeos/network/managed_state.h

Issue 16132002: Revert 202503 "Revert 202478 "Revert 202388 "Remove NetworkState..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chromeos/network/managed_state.h
===================================================================
--- trunk/src/chromeos/network/managed_state.h (revision 202513)
+++ trunk/src/chromeos/network/managed_state.h (working copy)
@@ -40,14 +40,9 @@
NetworkState* AsNetworkState();
DeviceState* AsDeviceState();
- // Called by NetworkStateHandler when a property was received. The return
- // value indicates if the state changed and is used to reduce the number of
- // notifications. The only guarantee however is: If the return value is false
- // then the state wasn't modified. This might happen because of
- // * |key| was not recognized.
- // * |value| was not parsed successfully.
- // * |value| is equal to the cached property value.
- // If the return value is true, the state might or might not be modified.
+ // Called by NetworkStateHandler when a property changes. Returns false if
+ // the property was not recognized, was not parsed successfully, or is
+ // unchanged (complex properties may be assumed to have changed).
virtual bool PropertyChanged(const std::string& key,
const base::Value& value) = 0;
« no previous file with comments | « trunk/src/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc ('k') | trunk/src/chromeos/network/network_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698