Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 161313002: Remove pp_ifdef from grd files in ui/. (Closed)

Created:
6 years, 10 months ago by newt (away)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Remove pp_ifdef from grd files in ui/. Generated using: > cd src/ui > git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g" BUG=343235 R=arv@chromium.org, joi@chromium.org, oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251895

Patch Set 1 #

Patch Set 2 : also removed pp_ifdef in xtb and css files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -95 lines) Patch
M ui/base/strings/app_locale_settings.grd View 7 chunks +13 lines, -13 lines 0 comments Download
M ui/base/strings/app_locale_settings_am.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ar.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_bn.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/app_locale_settings_hi.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ja.xtb View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/strings/app_locale_settings_kn.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ko.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/app_locale_settings_ml.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/app_locale_settings_mr.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_ta.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_te.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/strings/app_locale_settings_th.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/app_locale_settings_zh-CN.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/app_locale_settings_zh-TW.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/strings/ui_strings.grd View 9 chunks +24 lines, -24 lines 0 comments Download
M ui/resources/ui_resources.grd View 15 chunks +34 lines, -34 lines 0 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
+joi for review TBR arv@chromium.org for webui_resources.grd TBR oshima@chromium.org for ui_resources.grd
6 years, 10 months ago (2014-02-12 22:10:16 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-12 22:20:59 UTC) #2
oshima
lgtm
6 years, 10 months ago (2014-02-12 22:47:53 UTC) #3
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 10 months ago (2014-02-13 01:26:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/161313002/1
6 years, 10 months ago (2014-02-13 01:29:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:21:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-13 02:21:58 UTC) #7
Jói
LGTM
6 years, 10 months ago (2014-02-13 09:22:49 UTC) #8
newt (away)
6 years, 10 months ago (2014-02-19 00:24:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r251895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698